-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark StringContent mediaType parameters as nullable #103442
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The runtime/src/libraries/System.Net.Http/tests/FunctionalTests/StringContentTest.cs Line 134 in d2cada8
|
5aae602
to
8962b4b
Compare
Closes #83423
This PR doesn't change the behavior of
MediaTypeHeaderValue? mediaType
overloads wherenull
currently means "no media type".If we decide that's something we want to do, we can do so as a follow-up.
We have existing tests covering passing
null
to these consturctors.