Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard remaining IErrorInfo usage under FEATURE_COMINTEROP #103510

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

huoyaoyuan
Copy link
Member

The dummy definition in PAL can be removed now.

@huoyaoyuan huoyaoyuan marked this pull request as ready for review June 15, 2024 08:51
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 15, 2024
@jkotas jkotas added area-Interop-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 15, 2024
src/coreclr/inc/ex.h Outdated Show resolved Hide resolved
src/coreclr/inc/ex.h Outdated Show resolved Hide resolved
src/coreclr/inc/ex.h Outdated Show resolved Hide resolved
src/coreclr/inc/ex.h Outdated Show resolved Hide resolved
src/coreclr/inc/ex.h Outdated Show resolved Hide resolved
src/coreclr/vm/clrex.h Outdated Show resolved Hide resolved
src/coreclr/vm/clrex.h Outdated Show resolved Hide resolved
src/coreclr/vm/excep.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/excep.h Outdated Show resolved Hide resolved
src/coreclr/vm/excep.h Outdated Show resolved Hide resolved
huoyaoyuan and others added 2 commits June 24, 2024 12:58
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@huoyaoyuan
Copy link
Member Author

The remaining failure looks unrelated.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 8511002 into dotnet:main Jun 27, 2024
83 of 89 checks passed
@huoyaoyuan huoyaoyuan deleted the error-info branch June 27, 2024 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Interop-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants