Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paltests build #103519

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Fix paltests build #103519

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce719b6
Fix paltests build
am11 Jun 15, 2024
c82ebe9
.
am11 Jun 15, 2024
2a6bfdc
Address feedback
am11 Jun 15, 2024
5c15496
Update src/coreclr/pal/tests/palsuite/file_io/WriteFile/test2/WriteFi…
am11 Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coreclr/pal/tests/palsuite/file_io/ReadFile/test2/ReadFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ PALTEST(file_io_ReadFile_test2_paltest_readfile_test2, "file_io/ReadFile/test2/p

DWORD dwByteCount[] = { 0,
10,
strlen(szStringTest),
pageSize
(DWORD)strlen(szStringTest),
(DWORD)pageSize
// Commented out two negative test cases : Refer VSW 312690
// 2 * pageSize,
// -1
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/pal/tests/palsuite/file_io/WriteFile/test2/WriteFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ PALTEST(file_io_WriteFile_test2_paltest_writefile_test2, "file_io/WriteFile/test
const char * testString = "The quick fox jumped over the lazy dog's back.";
const int testStringLen = strlen(testString);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this implicit size_t -> int cast be made explicit as well? It is interesting that the compiler is not complaining about this strlen("constant string"), but it is complaining about the other strlen("constant string").

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaring it as DWORD also works without the explicit cast.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not depend on it. In general, compilers complain about any implicit narrowing these days.


DWORD dwByteCount[4] = {-1, 10, testStringLen, 0};
DWORD dwByteWritten[4] = {0, 10, testStringLen, 0};
DWORD dwByteCount[4] = {(DWORD)-1, 10, (DWORD)testStringLen, 0};
DWORD dwByteWritten[4] = {0, 10, (DWORD)testStringLen, 0};
BOOL bResults[] = {FALSE, TRUE, TRUE, TRUE};

const int BUFFER_SIZE = 2 * PAGESIZE;
Expand Down
Loading