-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NRBF] change StartsWithPayloadHeader to accept a Span rather than array #103636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
added
binaryformatter-migration
Issues related to the removal of BinaryFormatter and migrations away from it
area-System.Formats.Nrbf
labels
Jun 18, 2024
Note regarding the
|
1 similar comment
Note regarding the
|
jkotas
reviewed
Jun 18, 2024
src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/NrbfDecoder.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 18, 2024
Open
… because it's not guaranteed to work everywhere
jkotas
reviewed
Jun 27, 2024
src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/NrbfDecoder.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 27, 2024
jkotas
approved these changes
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Formats.Nrbf
binaryformatter-migration
Issues related to the removal of BinaryFormatter and migrations away from it
new-api-needs-documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the API Review I was asked why this method accepts an array rather than a readonly span of bytes. I've answered that because it's impossible to implement it for NS2.0 due to lack of primitives for endianness conversion. Back then I did not know that
BinaryPrimitives.ReverseEndianness
is supported on older frameworks.