Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NRBF] change StartsWithPayloadHeader to accept a Span rather than array #103636

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

adamsitnik
Copy link
Member

During the API Review I was asked why this method accepts an array rather than a readonly span of bytes. I've answered that because it's impossible to implement it for NS2.0 due to lack of primitives for endianness conversion. Back then I did not know that BinaryPrimitives.ReverseEndianness is supported on older frameworks.

@adamsitnik adamsitnik added binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it area-System.Formats.Nrbf labels Jun 18, 2024
@adamsitnik adamsitnik added this to the 9.0.0 milestone Jun 18, 2024
@adamsitnik adamsitnik requested a review from bartonjs June 18, 2024 12:49
@adamsitnik adamsitnik self-assigned this Jun 18, 2024
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

… because it's not guaranteed to work everywhere
@adamsitnik adamsitnik requested a review from jkotas June 27, 2024 15:46
@jkotas jkotas merged commit a900bbf into dotnet:main Jun 28, 2024
81 of 83 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Formats.Nrbf binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants