Arm64/SVE: Implemented `Scale` and `Sqrt` #103663

ebepho · 2024-06-18T18:32:21Z

Contributes to #99957

Scale stress test output:

Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Scale_float_int() : 7
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Scale_double_long() : 7
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Scale_float_int() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Scale_double_long() : 7
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

Sqrt stress test output:

Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Sqrt_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Sqrt_double() : 16
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Sqrt_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Sqrt_double() : 16
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

cc @dotnet/arm64-contrib

updating branch due to assert issue.

…when Op1 and Op2 have different types.

dotnet-issue-labeler · 2024-06-18T18:32:26Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-issue-labeler · 2024-06-18T18:32:28Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-18T18:32:59Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

kunalspathak · 2024-06-18T19:04:41Z

src/coreclr/jit/hwintrinsiclistarm64sve.h

@@ -184,11 +184,13 @@ HARDWARE_INTRINSIC(Sve, SaturatingIncrementBy32BitElementCount,
 HARDWARE_INTRINSIC(Sve, SaturatingIncrementBy64BitElementCount, -1, 3, true, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_sve_sqincd, INS_sve_uqincd, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_HasImmediateOperand|HW_Flag_HasEnumOperand|HW_Flag_SpecialCodeGen|HW_Flag_HasScalarInputVariant|HW_Flag_SpecialImport|HW_Flag_HasRMWSemantics)
 HARDWARE_INTRINSIC(Sve, SaturatingIncrementBy8BitElementCount, 0, 3, false, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_sve_sqincb, INS_sve_uqincb, INS_sve_sqincb, INS_sve_uqincb, INS_invalid, INS_invalid}, HW_Category_Scalar, HW_Flag_Scalable|HW_Flag_HasImmediateOperand|HW_Flag_HasEnumOperand|HW_Flag_SpecialCodeGen|HW_Flag_SpecialImport|HW_Flag_HasRMWSemantics)
 HARDWARE_INTRINSIC(Sve, SaturatingIncrementByActiveElementCount, -1, 2, true, {INS_invalid, INS_sve_sqincp, INS_sve_sqincp, INS_sve_sqincp, INS_sve_sqincp, INS_sve_sqincp, INS_sve_sqincp, INS_sve_sqincp, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_SpecialCodeGen|HW_Flag_SpecialImport|HW_Flag_BaseTypeFromSecondArg|HW_Flag_HasRMWSemantics)
+HARDWARE_INTRINSIC(Sve, Scale, -1, -1, false, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_sve_fscale, INS_sve_fscale}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_BaseTypeFromFirstArg|HW_Flag_EmbeddedMaskedOperation|HW_Flag_LowMaskedOperation|HW_Flag_HasRMWSemantics)


Don't think we need HW_Flag_BaseTypeFromFirstArg for this one. Can you double check?

kunalspathak · 2024-06-18T19:07:11Z

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs

+ ("_UnaryOpTestTemplate.template", "SimpleVecOpTest.template", new Dictionary<string, string> { ["TemplateName"] = "Simple", ["TemplateValidationLogic"] = SimpleVecOpTest_ValidationLogic }),
+ ("_BinaryOpTestTemplate.template", "VecPairBinOpTest.template", new Dictionary<string, string> { ["TemplateName"] = "Simple", ["TemplateValidationLogic"] = VecPairBinOpTest_ValidationLogic }),
+ ("_BinaryOp_SveTestTemplate.template", "SveVecPairBinOpTest.template", new Dictionary<string, string> { ["TemplateName"] = "Simple", ["TemplateValidationLogic"] = VecPairBinOpTest_ValidationLogic }),
+ ("_BinaryOpDifferentOpTypes_SveTestTemplate.template", "SveVecPairBinOpDifferentOpTypesTest.template", new Dictionary<string, string> { ["TemplateName"] = "Simple", ["TemplateValidationLogic"] = VecPairBinOpTest_ValidationLogic }),


Any reason why we cannot use SveVecBinOpTest*.template?

The SveVecBinOpTest is built for when the 2 arguments are of the same type. I made SveVecPairBinOpDifferentOpTypesTest to have a flexible variation.

Is it possible to tweak Op1BaseType and Op2BaseType and reuse SveVecBinOpTest? You might need some casting, but wondering if it is easy to do?

kunalspathak

Can you please rerun all the test to make sure that the changes made in template works? You can just run the tests in default mode with DOTNET_TieredCompilation=0 and no need to run stress test.

amanasifkhalid · 2024-06-24T22:45:10Z

Can you please rerun all the test to make sure that the changes made in template works? You can just run the tests in default mode with DOTNET_TieredCompilation=0 and no need to run stress test.

@kunalspathak I did this on my SVE machine, and everything passed in both test suites.

kunalspathak · 2024-06-24T22:46:58Z

/ba-g timeout issues

kunalspathak

LGTM

ebepho and others added 20 commits June 5, 2024 14:30

Added ConverToInt32 and ConvertToUInt32 for float inputs.

c738b77

Added flags to handle only low predicate registers.

35d39d9

Fixed merge conflicts.

7a781e1

Fix whitespace

1378d60

Remove special codegen flag

10c7a15

Added new test template for operations with different return types.

8004868

Merge branch 'main' into ConvertToInt32

af7ccd4

updating branch due to assert issue.

Add new test template.

8cb76da

Added api for ConvertToInt32 and ConvertToUInt 32 for double.

abe25fc

fix merge conflicts.

0f51f38

Merge branch 'dotnet:main' into main

7fabb91

Merge branch 'main' of github.com:ebepho/runtime

d5374ca

Merge branch 'main' of github.com:ebepho/runtime

4aa224d

Round SVE intrinsics for floats.

49a6c85

Completed Round SVE fp apis.

bd2702d

Merge branch 'main' of github.com:ebepho/runtime

56601b4

Merge branch 'main' into round

6ba83c3

Completed sve apis for scale and sqrt, added a new test template for …

ba922e7

…when Op1 and Op2 have different types.

Merge branch 'main' of github.com:ebepho/runtime

04071a3

Merge branch 'main' into scale+sqrt

9863b7c

dotnet-issue-labeler bot added area-System.Runtime.Intrinsics new-api-needs-documentation labels Jun 18, 2024

ebepho added the arm-sve Work related to arm64 SVE/SVE2 support label Jun 18, 2024

dotnet-policy-service bot assigned ebepho Jun 18, 2024

kunalspathak mentioned this pull request Jun 18, 2024

Arm64: Implement SVE APIs #99957

Closed

kunalspathak requested changes Jun 18, 2024

View reviewed changes

Merge branch 'main' of github.com:ebepho/runtime

ffcd267

ebepho added 2 commits June 19, 2024 11:40

Merge branch 'main' of github.com:ebepho/runtime

33626b3

Fixed test templates.

dc7f4dd

build-analysis bot mentioned this pull request Jun 20, 2024

STJ NullPropertyNameFail test failing in CI #103715

Closed

kunalspathak requested changes Jun 20, 2024

View reviewed changes

ebepho added 2 commits June 21, 2024 11:08

Merge branch 'main' of github.com:ebepho/runtime

da441d1

Merge branch 'main' into scale+sqrt

2d5b3a8

kunalspathak approved these changes Jun 24, 2024

View reviewed changes

kunalspathak merged commit ddcbc8b into dotnet:main Jun 24, 2024
154 of 167 checks passed

github-actions bot locked and limited conversation to collaborators Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arm64/SVE: Implemented `Scale` and `Sqrt` #103663

Arm64/SVE: Implemented `Scale` and `Sqrt` #103663

ebepho commented Jun 18, 2024 •

edited

Loading

dotnet-issue-labeler bot commented Jun 18, 2024

dotnet-issue-labeler bot commented Jun 18, 2024

dotnet-policy-service bot commented Jun 18, 2024

kunalspathak Jun 18, 2024

kunalspathak Jun 18, 2024

ebepho Jun 18, 2024 •

edited

Loading

kunalspathak Jun 18, 2024

kunalspathak left a comment

amanasifkhalid commented Jun 24, 2024

kunalspathak commented Jun 24, 2024

kunalspathak left a comment

Arm64/SVE: Implemented Scale and Sqrt #103663

Arm64/SVE: Implemented Scale and Sqrt #103663

Conversation

ebepho commented Jun 18, 2024 • edited Loading

dotnet-issue-labeler bot commented Jun 18, 2024

dotnet-issue-labeler bot commented Jun 18, 2024

dotnet-policy-service bot commented Jun 18, 2024

kunalspathak Jun 18, 2024

Choose a reason for hiding this comment

kunalspathak Jun 18, 2024

Choose a reason for hiding this comment

ebepho Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

kunalspathak Jun 18, 2024

Choose a reason for hiding this comment

kunalspathak left a comment

Choose a reason for hiding this comment

amanasifkhalid commented Jun 24, 2024

kunalspathak commented Jun 24, 2024

kunalspathak left a comment

Choose a reason for hiding this comment

Arm64/SVE: Implemented `Scale` and `Sqrt` #103663

Arm64/SVE: Implemented `Scale` and `Sqrt` #103663

ebepho commented Jun 18, 2024 •

edited

Loading

ebepho Jun 18, 2024 •

edited

Loading