Enbale TYP_MASK support for ARM64 #103818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
src/coreclr/jit/valuenum.cpp
Outdated
|
|
||
| #if defined(TARGET_XARCH) || defined(TARGET_ARM64) |
There was a problem hiding this comment.
You should use #if defined(FEATURE_MASKED_HW_INTRINSICS) instead instead of defined(TARGET_XARCH) || defined(TARGET_ARM64)
TIHan
approved these changes
Jun 22, 2024
This was referenced Jun 22, 2024
Open
|
/ba-g timeout issues |
rzikm
pushed a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Jun 24, 2024
* Enbale TYP_MASK support for ARM64 * cleanup: check for a FEATURE macro instead of TARGET * jit format --------- Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables support for
TYP_MASKconstants introduced in #99743 for ARM64 targets.Fixes assertion failures we sometimes see now during value numbering when stress testing SVE intrinsics:
@a74nh @kunalspathak @BruceForstall