Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Handle QMARK properly for LCL_ADDR propagation #103909

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

jakobbotsch
Copy link
Member

The assertions created/used need to take into account that qmark arms are only conditionally executed.

The assertions created/used need to take into account that qmark arms
are only conditionally executed.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 24, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch
Copy link
Member Author

@jkoritzinsky looks like there's some issues with the new jit-format job.

@jkoritzinsky
Copy link
Member

Looking into it now

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jun 25, 2024

Oddly large TP regressions. Apparently MSVC decided to stop inlining PushValue into PreOrderVisit:

Base: 106512123541, Diff: 106622408758, +0.1035%

250103641  : NA      : 62.46% : +0.2348% : private: void __cdecl LocalAddressVisitor::PushValue(struct GenTree **)                                                             
4952204    : +0.53%  : 1.24%  : +0.0046% : memset                                                                                                                              
-1087515   : -0.20%  : 0.27%  : -0.0010% : public: enum Compiler::fgWalkResult __cdecl GenTreeVisitor<class LocalAddressVisitor>::WalkTree(struct GenTree **, struct GenTree *)
-1087515   : -0.20%  : 0.27%  : -0.0010% : public: enum Compiler::fgWalkResult __cdecl LocalAddressVisitor::PostOrderVisit(struct GenTree **, struct GenTree *)                
-142728597 : -25.54% : 35.64% : -0.1340% : public: enum Compiler::fgWalkResult __cdecl LocalAddressVisitor::PreOrderVisit(struct GenTree **, struct GenTree *)                 

@jakobbotsch jakobbotsch marked this pull request as ready for review June 25, 2024 18:08
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @AndyAyersMS

No diffs. Large TP regressions from the inlining change shown in the comment above... I am hopeful that native PGO is going to sort that out.

@jakobbotsch jakobbotsch requested a review from AndyAyersMS June 25, 2024 18:09
@jakobbotsch jakobbotsch merged commit 9032715 into dotnet:main Jun 26, 2024
105 of 107 checks passed
@jakobbotsch jakobbotsch deleted the local-addr-prop-qmarks branch June 26, 2024 11:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants