JIT: Avoid reporting call-sites in MinOpts on all targets #103950
Conversation
When the call-sites have no interesting GC information we avoid reporting them, but this behavior was enabled only for x86/x64. Enable this on other platforms too. Fix dotnet#103917
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
src/coreclr/jit/gcencode.cpp
Outdated
| @@ -4065,13 +4065,7 @@ void GCInfo::gcMakeRegPtrTable( | |||
| { | |||
| GCENCODER_WITH_LOGGING(gcInfoEncoderWithLog, gcInfoEncoder); | |||
|
|
|||
| // TODO: Decide on whether we should enable this optimization for all | |||
| // targets: https://github.com/dotnet/runtime/issues/103917 | |||
| #ifdef TARGET_XARCH | |||
| const bool noTrackedGCSlots = compiler->opts.MinOpts() && !compiler->opts.jitFlags->IsSet(JitFlags::JIT_FLAG_PREJIT); | |||
There was a problem hiding this comment.
@jkotas do you know if there is any dependency on the call site locations by crossgen2? I'm not sure if the PREJIT condition can also be removed here.
There was a problem hiding this comment.
I do not think crossgen2 has any dependency on that. NativeAOT might have (unintentional) dependency on it - you may want to run NativeAOT outer loop.
The primary motivation for this feature was JIT throughput improvement. This condition is likely result of that thinking - spending the extra cycles for AOT is no big deal.
I do not see a problem with removing this condition.
There was a problem hiding this comment.
The change in https://github.com/dotnet/runtime/pull/102680/files#r1653150895 may make us sensitive to missing safepoints.
Mostly just a matter of changing asserts though. We know the caller site is GC-safe. (since we are in a GC-capable callee)
There was a problem hiding this comment.
Do you want me to revert the PREJIT change for now?
|
/azp run runtime-nativeaot-outerloop, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
When the call-sites have no interesting GC information we avoid reporting them, but this behavior was enabled only for x86/x64. Enable this on other platforms too.
Fix #103917