Expose the constants in TimeSpan #103993
Merged
Expose the constants in TimeSpan #103993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publicly expose the useful constants that `TimeSpan` had internally declared since they're rooted in hard reality and not changeable, and quite useful elsewhere. Everything is a `long` except `HoursPerDay` because that is useful in many non-TimeSpan contexts and rarely would overflow. Added /// documentation for newly public constants and updated _System.Runtime.cs_ assembly API reference. Use the newly exposed values in all the runtime places similar constants are declared in runtime **EXCEPT** did not use the `TimeSpan` constant in _EventLogInternal.cs_ since that source is also built for older frameworks, leave existing internal constant. In _Calendar.cs_, use an `int` cast at the call-sites to `Add` method to prevent performance degradation, these calls are known not to overflow. Fixes dotnet#94545
|
Note regarding the |
1 similar comment
|
Note regarding the |
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Jun 25, 2024
This was referenced Jun 26, 2024
Open
|
/ba-g the failures are already tracked in the dnceng dotnet/dnceng#3007. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publicly expose the useful constants that
TimeSpanhad internally declared since they're rooted in hard reality and not changeable, and quite useful elsewhere. Everything is alongexceptHoursPerDaybecause that is useful in many non-TimeSpan contexts and rarely would overflow.Added /// documentation for newly public constants and updated System.Runtime.cs assembly API reference.
Use the newly exposed values in all the runtime places similar constants are declared in runtime EXCEPT did not use the
TimeSpanconstant in EventLogInternal.cs since that source is also built for older frameworks, leave existing internal constant.In Calendar.cs, use an
intcast at the call-sites toAddmethod to prevent performance degradation, these calls are known not to overflow.Fixes #94545