Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios][HybridGlobalization] Fix default culture #104071

Merged
merged 2 commits into from
Jul 1, 2024
Merged

[ios][HybridGlobalization] Fix default culture #104071

merged 2 commits into from
Jul 1, 2024

Conversation

mkhamoyan
Copy link
Contributor

Fixes #95195

@mkhamoyan mkhamoyan self-assigned this Jun 27, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mkhamoyan mkhamoyan marked this pull request as ready for review June 27, 2024 11:03
@build-analysis build-analysis bot mentioned this pull request Jun 27, 2024
Open
3 tasks
This was referenced Jun 27, 2024
Closed
Open
matouskozak
matouskozak approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@matouskozak matouskozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation!

@mkhamoyan mkhamoyan merged commit b3ee47d into dotnet:main Jul 1, 2024
156 of 180 checks passed
@mkhamoyan mkhamoyan deleted the fix_default_culture branch July 1, 2024 07:00
@mkhamoyan mkhamoyan mentioned this pull request Jul 3, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matouskozak matouskozak matouskozak approved these changes

@lewing lewing Awaiting requested review from lewing

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees

@mkhamoyan mkhamoyan

Labels
area-System.Globalization os-ios Apple iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS][non-icu] HybridGlobalization throwing exception culture identifier not found when creating culture
2 participants
@mkhamoyan @matouskozak