Arm64/Sve: Rewrite how ConditionalSelect wraps the embedded mask operations #104248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/arm64-contrib |
tannergooding
approved these changes
Jul 3, 2024
This was referenced Jul 3, 2024
Open
|
@dotnet/arm64-contrib |
amanasifkhalid
approved these changes
Jul 3, 2024
src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Show resolved
Hide resolved
src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Show resolved
Hide resolved
src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Show resolved
Hide resolved
src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Show resolved
Hide resolved
It does. Here are the results. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For APIs does not take mask as 1st parameter, but generates only predicated instructions like Abs, we wrap it in
CndSel(AllTrue, Operation(), Zero). If user however, writes a code explicitly usingCndSeloperation, we would skip wrapping it, because we were already in that form. However, this caused issues when such embedded mask operation was used inmergeValueoperation, something likeCndSel(mask, trueValue, Operation()).To solve this, now we will wrap the operation, regardless of if it is inside
CndSelor not. For example,CndSel(mask, Operation(), mergeValue)=>CndSel(mask, CndSel(AllTrue, Operation(), Zero) mergeValue)CndSel(mask, trueValue, Operation())=>CndSel(mask, trueValue, CndSel(AllTrue, Operation(), Zero))One of these forms will then get handled in new lowering method to handle
CndSelnodes in general to do the right operation.As part of this, I have updated all the test templates to pass
Operation()formergeValue.TODO:
Add validation forEdit: For now, will add this as a separate pass.CndSel(mask, Operation(), Operation())All tests are passing. Results here.
Thanks to @tannergooding for spending time with me for coming up with the design.