Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] default WasmDebugLevel to 0 for tests #104361

Merged
merged 5 commits into from
Jul 4, 2024
Merged

[browser] default WasmDebugLevel to 0 for tests #104361

merged 5 commits into from
Jul 4, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 3, 2024 •
edited
Loading

  • default WasmDebugLevel to 0 for tests on CI
  • print size of linear memory at the end of each test
  • reduce timeouts

Fixes #103829
Fixes #103246

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jul 3, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jul 3, 2024
@pavelsavara pavelsavara self-assigned this Jul 3, 2024
@pavelsavara pavelsavara requested a review from lewing as a code owner July 3, 2024 12:28
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara changed the title [browser] default WasmDebugLevel to 0 for tests on CI [browser] default WasmDebugLevel to 0 for tests Jul 3, 2024
This was referenced Jul 3, 2024
Open
Closed
Open
Open
Closed
Open
@pavelsavara
Copy link
Member Author

/ba-g filled #104419 and #104418

@pavelsavara pavelsavara merged commit dd6840d into dotnet:main Jul 4, 2024
89 of 92 checks passed
@pavelsavara pavelsavara deleted the WasmDebugLevel_0 branch July 4, 2024 08:55
@build-analysis build-analysis bot mentioned this pull request Jul 4, 2024
Open
This was referenced Jul 4, 2024
Merged
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 4, 2024
Closed
maraf added a commit to maraf/runtime that referenced this pull request Jul 12, 2024
@maraf
[browser] default WasmDebugLevel to 0 for tests (dotnet#104361)
f18a052
@maraf maraf mentioned this pull request Jul 15, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@akoeplinger akoeplinger akoeplinger left review comments

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@maraf maraf Awaiting requested review from maraf

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[browser] System.Memory.Tests is taking too long on FF [browser][ST] Wasm tests timeout
3 participants
@pavelsavara @akoeplinger @ilonatommy