Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi] sdk22 path #104379

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[wasi] sdk22 path #104379

merged 1 commit into from
Jul 10, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 3, 2024 •
edited
Loading

  • this renames WASI_SDK_PATH to WASI_SDK22_PATH in order to avoid local installation of older WASI SDK.
  • fix WASI SDK provisioning
  • hotfix wasm-component-ld to v0.5.4, until WASI SDK 23

The usage of local older WASI SDK could be seen in log

2024-07-09T13:55:22.5825795Z   -- The C compiler identification is Clang 17.0.6
...
2024-07-09T13:55:22.7482610Z     The C compiler
2024-07-09T13:55:22.7482869Z   
2024-07-09T13:55:22.7483204Z       "/usr/local/wasi-sdk//bin/clang"

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Jul 3, 2024
@pavelsavara pavelsavara self-assigned this Jul 3, 2024
This was referenced Jul 4, 2024
Open
Open
Open
Open
Open
Open
Closed
Closed
@pavelsavara pavelsavara marked this pull request as ready for review July 9, 2024 17:13
This was referenced Jul 9, 2024
Open
Closed
ilonatommy
ilonatommy approved these changes Jul 10, 2024
View reviewed changes
eng/native/gen-buildsys.sh Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Jul 10, 2024
Closed
@pavelsavara pavelsavara merged commit 812cb93 into dotnet:main Jul 10, 2024
155 of 160 checks passed
@pavelsavara pavelsavara deleted the wasi_sdk22 branch July 10, 2024 10:44
@pavelsavara pavelsavara mentioned this pull request Jul 10, 2024
Merged
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@matouskozak
Revert "[WASI] use WASI_SDK22_PATH variable (dotnet#104379)"
6641e91 
This reverts commit 812cb93.
@pavelsavara pavelsavara mentioned this pull request Jul 11, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @ilonatommy