Small clean up in gtMarkAddrMode #104387
Merged
Small clean up in gtMarkAddrMode #104387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
PTAL @jakobbotsch @AndyAyersMS @dotnet/jit-contrib Diffs. A few small regressions where we no longer have "DONT_CSE" where we used to. I am rewriting the whole |
EgorBo
commented
Jul 3, 2024
| { | ||
| // op1 isn't base or idx. Is this possible? Or should there be an assert? | ||
| } | ||
| op2->gtFlags |= GTF_ADDRMODE_NO_CSE; |
There was a problem hiding this comment.
a temp quirk to revert some size regressions
jakobbotsch
approved these changes
Jul 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103577