Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the CPUID and XSAVE logics for APX #104637
Update the CPUID and XSAVE logics for APX #104637
Changes from all commits
9f8f67c
a68865c
6dfb92b
b998cdf
3446e28
9bc008a
44163d7
600abd0
81b47c6
d516feb
42f1729
d90bf49
79b23c8
8e1ba4a
ea8949f
597e797
117c401
8cc7e8e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some way to do an
#if
to only use the raw hex on assemblers without support today?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not aware of, do we have sth like LLVM version identifier defined in our code base?
I think this chunk is meant to be converted to
MOV
instructions once we have LLVM with official APX supports, and the code may not have actual use cases until we have machines with APX.@tannergooding, could you share some thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its fine as is, I don't think its worth supporting code that we can't reliably test and maintain in CI at this point in time.
Rather, lets just have the one path and update when the toolchain can finally be updated to LLVM 19/20 or later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this too.