-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Perl scripts to C# in coreclr #104867
Conversation
src/coreclr/inc/OpCodeGen.pl
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't bother to add replacement for this one as it generates C# sources which are diverged (see, e.g. src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/OpCodeType.cs
).
Tagging subscribers to this area: @hoyosjs |
373de1f
to
aff296b
Compare
6fcc5da
to
8a4e0f4
Compare
8a4e0f4
to
5849155
Compare
Here comes the desirement of c# script file with project information included... |
PowerShell might be a better fit. |
These projects are not used by the build. They are basically for coreclr devs to visualize data cross platform. They are also not interesting for devs porting to new platforms where .NET SDK is not yet available (it works with cross-build though). We have similar tools written in C# in this category, which is why I've chosen C#. |
src/coreclr/dlls/mscordac/DacToWindbgLongName/DacToWindbgLongName.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing dac script LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
No description provided.