Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Perl scripts to C# in coreclr #104867

Merged
merged 13 commits into from
Jul 24, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Jul 14, 2024

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 14, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't bother to add replacement for this one as it generates C# sources which are diverged (see, e.g. src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/OpCodeType.cs).

Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@am11 am11 force-pushed the feature/cleanup-perl-scripts branch from 373de1f to aff296b Compare July 14, 2024 10:46
@am11 am11 changed the title Rewrite perl scripts to C# in coreclr Convert Perl scripts to C# in coreclr Jul 14, 2024
@am11 am11 force-pushed the feature/cleanup-perl-scripts branch 4 times, most recently from 6fcc5da to 8a4e0f4 Compare July 14, 2024 13:47
@am11 am11 force-pushed the feature/cleanup-perl-scripts branch from 8a4e0f4 to 5849155 Compare July 14, 2024 13:48
@huoyaoyuan
Copy link
Member

Here comes the desirement of c# script file with project information included...

@teo-tsirpanis
Copy link
Contributor

PowerShell might be a better fit.

@am11
Copy link
Member Author

am11 commented Jul 14, 2024

These projects are not used by the build. They are basically for coreclr devs to visualize data cross platform. They are also not interesting for devs porting to new platforms where .NET SDK is not yet available (it works with cross-build though). We have similar tools written in C# in this category, which is why I've chosen C#.

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing dac script LGTM

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 7847b75 into dotnet:main Jul 24, 2024
91 checks passed
@am11 am11 deleted the feature/cleanup-perl-scripts branch July 24, 2024 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants