-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact query from HttpTelemetry #104970
Redact query from HttpTelemetry #104970
Conversation
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Http/src/System/Net/Http/HttpTelemetry.cs
Outdated
Show resolved
Hide resolved
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also
runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/RedirectHandler.cs
Line 58 in 0f2e63f
HttpTelemetry.Log.Redirect(redirectUri.AbsoluteUri); |
Is there a reason why we're skipping it?
src/libraries/System.Net.Http/src/System/Net/Http/HttpTelemetry.cs
Outdated
Show resolved
Hide resolved
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
Breaking change doc is created: dotnet/docs#42794 |
Follow up on #103769
Redacts query string from the official HttpTelemetry (EventSource "System.Net.Http"). Uses the same opt out as distributed tracing (Activity) and
HttpClientFactory
logging. Doesn't touch private events (EventSource "Private.InternalDiagnostics.*").Fixes #74340
cc @CarnaViire