Emit More EventSource Data For Metrics Measurements #104993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekgh
added
area-System.Diagnostics.Metric
and removed
area-System.Diagnostics.Tracing
labels
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 17, 2024
Open
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Open
stephentoub
reviewed
Jul 17, 2024
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Helpers.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 17, 2024
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 17, 2024
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Helpers.cs
Outdated
Show resolved
Hide resolved
noahfalk
approved these changes
Jul 17, 2024
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Meter.cs
Outdated
Show resolved
Hide resolved
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
|
@wiktork @jander-msft - heads up since dotnet-monitor probably wants to consume this data too. Unless we get some extension the checkin deadline is the end of the week so this is likely to go fast. |
CodeBlanch
reviewed
Jul 17, 2024
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Jul 17, 2024
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
tarekgh
force-pushed
the
EmitMoreEventSourceDataForMetricsMeasurments
branch
from
c73dfed
to
ed34eae
Compare
…iagnostics/Helpers.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
tarekgh
force-pushed
the
EmitMoreEventSourceDataForMetricsMeasurments
branch
from
ed34eae
to
95024ec
Compare
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@noahfalk I have updated the code according to our offline discussion with introducing the instrument Id in our emitted events. If you are interested in looking at the update, please look at the last commit. Thanks! |
This was referenced Jul 21, 2024
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93097 and #93767
This change enables the emission of additional metrics data during measurement publishing. Specifically, it will emit the instrument's formatted tags and hash, as well as the meter's formatted tags, scope hash, and meter hash. With this extra data, aggregators can easily differentiate between instruments created with identical parameters such as name, tags, and units. Similarly, it allows for distinguishing between meters created with the same parameters, such as meter name, version, tags, and scope.