Fix the ExposedLocalsNumbering test #105037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test had a stack corrupting race condition: 1) Main thread returns from "Main". 2) Main thread calls some runtime code on the stack of former "Main". 3) Mutator thread writes to the "safeIndex" variable, which is now part of that runtime's code stack. 4) Things crash. Fix by 'parking' the mutated index in some dynamic memory instead.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
SingleAccretion
force-pushed
the
Fix-ExposedLocalsNumbering
branch
from
667e074 to
e61522b
Compare
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet/jit-contrib |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #80184. See the first commit message for the description of the bug.