Revert "Use generic math for floating point formatting" for Single and Double #105038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Reminder for @fanyang-mono - in case you want to get this in for Preview 7 snap. |
|
@jkotas, based on #104076 (comment), I'm assuming you're recommending we close this rather than merge this, yes? |
stephentoub
added
the
NO-MERGE
|
I would like to see the result of #104076 (comment). If the regression is just in throughput micro-benchmark and there is no significant binary size regression, I think we should close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #102683. Closes #104076.
The first commits reverts the original PR. The second commit reapplies it on
Half, with suggested renaming.