-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mono] Intrinsify Unsafe API's #105150
[Mono] Intrinsify Unsafe API's #105150
Conversation
Tagging subscribers to this area: @lambdageek, @steveisok |
Make sure to add comments to runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs Lines 25 to 31 in 19f0385
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Add/Subtract and Read/Write changes LGTM
BitCast also LGTM, but I'm probably not the right person to review that since I wrote some of the code in a previous prototype
This seems to be a very fragile way of keeping track which methods are intrinsified by each runtime. We probably should come up a better way of doing it. |
Fixes #101495
The implementation of
Unsafe.BitCast
was extracted from #103915