[mono] Improve iOS sample Makefile #105316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where we were still harcoding the Debug config for tasks even though that changed with dotnet#84931. Also align the Makfile to make it more similar to the iOS-NativeAOT one.
dotnet-issue-labeler
bot
added
the
needs-area-label
akoeplinger
added
area-Build-mono
and removed
needs-area-label
|
Overall looks good, but we will need to update the perf jobs to pass the new make variables, e.g.: |
|
@ivanpovazan thanks, fixed |
This was referenced Jul 23, 2024
ivanpovazan
reviewed
Jul 24, 2024
| /p:MonoEnableLLVM=false \ | ||
| /p:MonoForceInterpreter=true \ | ||
| /p:DeployAndRun=$(DEPLOY_AND_RUN) \ | ||
| /p:EnableAppSandbox=$(APP_SANDBOX) \ | ||
| /bl | ||
|
|
||
| clean: | ||
| rm -rf bin | ||
| rm -rf obj bin *.binlog |
There was a problem hiding this comment.
nit: I might be wrong, but if I remember correctly the intermediate dir for the Mono sample will be in artifacts folder.
For NativeAOT iOS sample we did not set it up correctly so we are creating both bin and obj next to the project file.
There was a problem hiding this comment.
I checked and we have the folders in the current directory too.
ivanpovazan
approved these changes
Jul 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where we were still harcoding the Debug config for tasks even though that changed with #84931.
Also align the Makfile to make it more similar to the iOS-NativeAOT one.