[WASI] bump WASI SDK 24 #105317
Merged
[WASI] bump WASI SDK 24 #105317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
|
cc @dicej |
dicej
approved these changes
Jul 29, 2024
pavelsavara
force-pushed
the
wasi_sdk_23
branch
from
38cf8e4 to
7d2c129
Compare
Co-authored-by: Joel Dice <joel.dice@fermyon.com>
Co-authored-by: Joel Dice <joel.dice@fermyon.com>
Co-authored-by: Joel Dice <joel.dice@fermyon.com>
Co-authored-by: Joel Dice <joel.dice@fermyon.com>
pavelsavara
requested review from
maraf,
akoeplinger,
lewing and
marek-safar
as code owners
akoeplinger
approved these changes
Aug 5, 2024
This was referenced Aug 5, 2024
dicej
reviewed
Aug 6, 2024
| @@ -368,8 +347,8 @@ JS_ENGINES = [NODE_JS] | |||
| Condition="'$(ActualWasiSdkVersion)' != '$(ExpectedWasiSdkVersion)'" /> | |||
|
|
|||
| <!-- LLVM in WASI SDK 22 will call wasm-opt when found on the PATH. But it will fail because wasm-opt can't read the WASM components. | |||
| After we upgrade to WASI SDK 23, we could use no-wasm-opt LLVM option to avoid this issue. | |||
| See https://github.com/llvm/llvm-project/pull/95208#issuecomment-2220400454 | |||
| After we upgrade to WASI SDK 23.x, we could use no-wasm-opt LLVM option to avoid this issue. | |||
There was a problem hiding this comment.
Is this comment still relevant?
There was a problem hiding this comment.
I believe that it will land with LLVM 19, we are still on LLVM 18.
I will update the comment in another PR and I updated #104773
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERSION22PATCHEDtoVERSION2423.0.1v0.2.10.29Contributes to #104773
Contributes to #105290