Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib-ng: avoid suppressing WD4242 and WD4244 #105433

Merged
merged 19 commits into from
Jul 25, 2024

Remove the assert includes too

d99757e
Select commit
Loading
Failed to load commit list.
Merged

zlib-ng: avoid suppressing WD4242 and WD4244 #105433

Remove the assert includes too
d99757e
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis succeeded Jul 25, 2024 in 0s

.NET Result Analysis

Details

‼️ Build Analysis Check Result has been manually overridden

  • The build analysis check result has been updated by the user for the following reason: Failure is unrelated https://github.com//issues/105440 and has already been fixed in main https://github.com//pull/105445
  • The check result has changed from Failure to Success

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

⚠️ The following pipeline(s) will not be analyzed as has been explicited excluded from analysis

Test Failures (1 tests failed)

🔹 [All failing tests from runtime]

    ❌ System.Text.Json.Serialization.Tests.JsonElementTests.DeepEquals_TooDeepJsonDocument_ThrowsInsufficientExecutionStackException [Console] [Details] [Artifacts] [5.56% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration
    Exception Message
    Assert.Throws() Failure: No exception was thrown
Expected: typeof(System.InsufficientExecutionStackException)
    CallStack
       at System.Text.Json.Serialization.Tests.JsonElementTests.DeepEquals_TooDeepJsonDocument_ThrowsInsufficientExecutionStackException() in /_/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/JsonElementTests.cs:line 237
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs:line 57

Was this helpful? Yes No

View more details on Build Analysis