[browser] Marshalling of resolved Tasks/promises is not resolved in JS/C# #105464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WBT is too heavy weight integration test for this. Let's add test to |
This was referenced Jul 29, 2024
pavelsavara
reviewed
Jul 29, 2024
...ices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.mjs
Outdated
Show resolved
Hide resolved
|
MT JSExport - disabled, re-run with update. |
pavelsavara
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
This was referenced Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR solves the problem with void Task marshalling. Fixes #104772.
Promise is resolved. Success.-> regressionJSImportthat is the same as the issue but with opposite marshalling direction.cc @pavelsavara
Might be connected: #95411