Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CertificateCallbackThrowPropagates on Alpine #105489

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Enable CertificateCallbackThrowPropagates on Alpine #105489

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e23546c
Enable CertificateCallbackThrowPropagates
liveans Jul 25, 2024
f16d1dc
Skip Test on platforms other than Alpine
liveans Jul 25, 2024
c4b1ac4
Review feedback
liveans Jul 26, 2024
3332fdd
Change condition to check MsQuic Version instead of Specific Distro
liveans Jul 29, 2024
ea9559e
Delete unused property
liveans Jul 29, 2024
03e617a
Merge branch 'main' into enable_99074_disabled_test
liveans Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public class MsQuicTests : QuicTestBase, IClassFixture<CertificateSetup>
{
private static byte[] s_data = "Hello world!"u8.ToArray();
readonly CertificateSetup _certificates;
static bool SupportsAsyncCertValidation => QuicTestCollection.MsQuicVersion >= new Version(2, 4);

public MsQuicTests(ITestOutputHelper output, CertificateSetup setup) : base(output)
{
Expand Down Expand Up @@ -353,7 +354,7 @@ public async Task UntrustedClientCertificateFails()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/99074")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/99074", typeof(MsQuicTests), nameof(SupportsAsyncCertValidation))]
public async Task CertificateCallbackThrowPropagates()
{
using CancellationTokenSource cts = new CancellationTokenSource(PassingTestTimeout);
Expand Down
Loading