Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Console.Write{Line} span overloads #105531

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Add Console.Write{Line} span overloads #105531

merged 1 commit into from
Aug 15, 2024

Conversation

stephentoub
Copy link
Member

Closes #103500

@stephentoub stephentoub added this to the 10.0.0 milestone Jul 26, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@build-analysis build-analysis bot mentioned this pull request Jul 26, 2024
Closed
adamsitnik
adamsitnik approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @stephentoub

jeffhandley
jeffhandley approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) until main targets .NET 10.

@jeffhandley jeffhandley added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 1, 2024
@stephentoub stephentoub removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 15, 2024
@stephentoub stephentoub merged commit 9ea7e1a into dotnet:main Aug 15, 2024
84 checks passed
@stephentoub stephentoub deleted the consolewritespan branch August 15, 2024 01:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@jeffhandley jeffhandley jeffhandley approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Console new-api-needs-documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Console.Write* convenience overloads for span
3 participants
@stephentoub @jeffhandley @adamsitnik