Implement IUtf8SpanParsable on Guid
#105654
Open
+231
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
needs-area-label
|
Note regarding the |
1 similar comment
|
Note regarding the |
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree |
3 tasks
huoyaoyuan
reviewed
Jul 30, 2024
lilinus
reviewed
Jul 30, 2024
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/GuidTests.cs
Show resolved
Hide resolved
| // | ||
|
|
||
| /// <inheritdoc cref="IUtf8SpanParsable{TSelf}.Parse(ReadOnlySpan{byte}, IFormatProvider?)" /> | ||
| public static Guid Parse(ReadOnlySpan<byte> utf8Text, IFormatProvider? provider) => Parse(utf8Text); |
There was a problem hiding this comment.
Should these methods with IFormatProvider be explicitly implemented? I see that is the case for e.g. IUtf8SpanFormattable method. C.f. #81500 (comment)
There was a problem hiding this comment.
I raised this question in my linked API proposal (#105653), but that was closed as already approved, so I guess this is how it's supposed to be?
lilinus
reviewed
Jul 30, 2024
Sorted methods in ref assembly. Removed unneccesary ToSpan(). Unified DecodeByte logic. Used TrimUtf8() instead of bespoke function.
Update tests to include unicode whitespace characters. Add IFormatProvider overloads to tests.
lilinus
reviewed
Jul 31, 2024
lilinus
reviewed
Jul 31, 2024
huoyaoyuan
added
area-System.Runtime
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #81500
API Proposal: #105653
This implements
IUtf8SpanParsableonGuidby making the core of the parsing logic generic onTChar : IUtfChar<TChar>. A small amount of it is duplicated, with a version forcharandbyte, because doing so prevented a performance regression forcharparsing.In addition, it adds a Utf8
ParseandTryParsewithout the unusedIFormatProviderparameter, to match howISpanParsablewas implemented. I did not add Utf8 overloads forParseExact, but that can be discussed in the linked API proposal.