[LoongArch64] Fix the add overflow check for A=A+A. #105674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@shushanhf Could you please review this change？ |
huoyaoyuan
reviewed
Jul 30, 2024
| @@ -4918,7 +4918,7 @@ regNumber emitter::emitInsTernary(instruction ins, emitAttr attr, GenTree* dst, | |||
|
|
|||
| if (needCheckOv) | |||
| { | |||
| emitIns_R_R_R(INS_or, attr, REG_R21, nonIntReg->GetRegNum(), REG_R0); | |||
| emitIns_R_R_I(INS_ori, attr, REG_R21, nonIntReg->GetRegNum(), 0); | |||
There was a problem hiding this comment.
Is this change necessary? Does it have any difference between OR zr and ORI imm#0?
Which one is used consistently in codegen for LA?
There was a problem hiding this comment.
Here OR zr and ORI imm#0 do the same thing, but ORI imm#0 is used consistently for $rd=$rn.
shushanhf
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
|
@jakobbotsch Could you please review this PR? |
jakobbotsch
approved these changes
Aug 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.