Revert "Use IndexOf for bounded loops in a regex code gen" #105735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08e0f89.
|
Do you mean fixes #102203? |
Yes, thanks. |
|
@steveharter or @MihaZupan, this is just a revert. Could you review / approve? Thanks! |
MihaZupan
approved these changes
Aug 2, 2024
|
thanks |
This was referenced Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #101899
Fixes #102203
Optimization didn't pan out as intended. It helps the cases it was supposed to, but those are rare compared to those it regressed (a little).