JIT: Remove GT_CAST handling in Lowering::IsValidConstForMovImm
#106092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
jakobbotsch
reviewed
Aug 7, 2024
src/coreclr/jit/lowerarmarch.cpp
Outdated
| @@ -1931,17 +1931,21 @@ bool Lowering::IsValidConstForMovImm(GenTreeHWIntrinsic* node) | |||
| GenTree* op1 = node->Op(1); | |||
| GenTree* castOp = nullptr; | |||
|
|
|||
| // TODO-Casts: why don't we fold the casts? MinOpts? | |||
| // In MinOpts, casts won't be folded during importation | |||
| if (varTypeIsIntegral(node->GetSimdBaseType()) && op1->OperIs(GT_CAST)) | |||
There was a problem hiding this comment.
Does removing this handling entirely have any significant diffs outside MinOpts?
There was a problem hiding this comment.
I tried removing this, and (surprisingly?) I didn't get any diffs, so this code pattern doesn't seem common enough to even help MinOpts all that much. Maybe we should get rid of it altogether.
amanasifkhalid
changed the title
GT_CAST removal in Lowering::IsValidConstForMovImm if it might change immediateGT_CAST handling in Lowering::IsValidConstForMovImm
jakobbotsch
approved these changes
Aug 8, 2024
|
No diffs in CI, either. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106020 (comment).