Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IEnumerator<T> on ref struct enumerators #106309

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Implement IEnumerator<T> on ref struct enumerators #106309

wants to merge 8 commits into from

Conversation

AlexRadch
Copy link
Contributor

Close #105276

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Aug 13, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2024
This was referenced Aug 13, 2024
Open
Open
Open
Open
Closed
@am11 am11 added area-System.Memory and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 13, 2024
This was referenced Aug 13, 2024
Open
Open
This was referenced Aug 13, 2024
Open
Closed
This was referenced Aug 14, 2024
Closed
Open
huoyaoyuan
huoyaoyuan reviewed Aug 22, 2024
View reviewed changes
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpanHelpers.cs
@@ -222,7 +222,7 @@ public static void ValidateStrides(ReadOnlySpan<nint> strides, ReadOnlySpan<nint
/// <param name="length">The length of the TensorSpan we are iterating over.</param>
public static void AdjustIndexes(int curIndex, nint addend, Span<nint> curIndexes, scoped ReadOnlySpan<nint> length)
{
if (addend <= 0 || curIndex < 0)
if (addend <= 0 || curIndex < 0 || length[curIndex] <= 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's hitting this? Will this affect behavior of other public API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It removes Access violation when length[curIndex] is zero. Now code throws an Access violation for an empty tensor.
That was incorrect behavior. I add tests for empty tensor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelgsharp

@AlexRadch
Revert some changes Regex.EnumerateMatches.cs after code review
2f60a8b 
Calling MoveNext after it's already returned false is a programmer error. It is not something we need to optimize for.
@build-analysis build-analysis bot mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Implement IEnumerator<T> on ref struct enumerators
4 participants
@AlexRadch @stephentoub @huoyaoyuan @am11