Disabled stackoverflow tests with largeframe for RISCV64 #106383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For bigger structures than the page size, the current way of calculating whether failureAddress is a part of the stack is not always proper. Because siginfo_t structure with failureAddress (si_addr field) comes from OS the problem must be related with SP or with the formula: (failureAddress - (sp - GetVirtualPageSize())) < 2 * GetVirtualPageSize() which is used to check if SIGSEGV is a stack overflow.
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @mangod9 |
|
Like #106540 (comment), please update the title. |
tomeksowi
approved these changes
Aug 20, 2024
ashaurtaev
approved these changes
Aug 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For bigger structures than the page size, the current way of calculating whether failureAddress is a part of the stack is not always proper. Because siginfo_t structure with failureAddress (si_addr field) comes from OS the problem must be related with SP or with the formula:
which is used to check if SIGSEGV is a stack overflow.
IMO, this case is similar to ARM64 case.
cc @dotnet/samsung. Part of #84834.