-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Allow to build browser in library mode #106388
Conversation
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
Outdated
Show resolved
Hide resolved
src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs follow up on existing comments
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
This feels wrong, we're plumbing the rid down to the generator rather than dealing with runtime init ordering in the browser case. I'd rather we unconditionally emit the intiialize_runtime call and have it assert when it can't actually do the initialization. |
We are initializing runtime for browser in the place™️ manually. I guess we can have wrap the |
By this PR we are supporting library mode for browser.
Contributes to #77191