Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Allow to build browser in library mode #106388

Merged
merged 13 commits into from
Oct 3, 2024

Conversation

mkhamoyan
Copy link
Contributor

@mkhamoyan mkhamoyan commented Aug 14, 2024

By this PR we are supporting library mode for browser.

Contributes to #77191

@mkhamoyan mkhamoyan added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Aug 14, 2024
@mkhamoyan mkhamoyan self-assigned this Aug 14, 2024
@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan mkhamoyan marked this pull request as ready for review August 14, 2024 12:22
@mkhamoyan mkhamoyan requested a review from lewing August 14, 2024 12:28
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs follow up on existing comments

@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Sep 10, 2024
@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing
Copy link
Member

lewing commented Sep 24, 2024

This feels wrong, we're plumbing the rid down to the generator rather than dealing with runtime init ordering in the browser case. I'd rather we unconditionally emit the intiialize_runtime call and have it assert when it can't actually do the initialization.

@maraf
Copy link
Member

maraf commented Sep 25, 2024

This feels wrong, we're plumbing the rid down to the generator rather than dealing with runtime init ordering in the browser case. I'd rather we unconditionally emit the intiialize_runtime call and have it assert when it can't actually do the initialization.

We are initializing runtime for browser in the place™️ manually. I guess we can have wrap the mono_wasm_load_runtime in initialize_runtime for browser case, still call it manually and leave the generator untouched

@maraf maraf added this to the 10.0.0 milestone Oct 1, 2024
@maraf maraf merged commit 2358c59 into dotnet:main Oct 3, 2024
35 of 38 checks passed
sirntar pushed a commit to sirntar/runtime that referenced this pull request Oct 3, 2024
lambdageek pushed a commit to lambdageek/runtime that referenced this pull request Oct 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono linkable-framework Issues associated with delivering a linker friendly framework os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants