Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Clean emsdk setup #106403

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

[wasm] Clean emsdk setup #106403

wants to merge 40 commits into from

Commits on Aug 14, 2024

  1. Remove embedded scripts, fix build on Linux.

    @ilonatommy
    ilonatommy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e064ec6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-105439-changing-runtime-only - fix froze… 

    …n cache.
    @ilonatommy
    ilonatommy committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7bc1637 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Windows - almost fixed, missing native build access to EMSDK_PATH.

    @ilonatommy
    ilonatommy committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    60bfafc View commit details
    Browse the repository at this point in the history

  2. Fix $(EMSDK_PATH) is missing is missing some paths.

    @ilonatommy
    ilonatommy committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    07ce65d View commit details
    Browse the repository at this point in the history

  3. Fix wasi.

    @ilonatommy
    ilonatommy committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5636d09 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix-105439-changing-runtime-only

    @ilonatommy
    ilonatommy committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ea2d900 View commit details
    Browse the repository at this point in the history

  5. Cleanup - move the pre-env script logic to emscripten provisioning.

    @ilonatommy
    ilonatommy committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    4a3e122 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Move remaining emsdk-provision bits to provision target.

    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bf2c1bb View commit details
    Browse the repository at this point in the history

  2. Fix: it's an Item, not a property.

    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    97a5513 View commit details
    Browse the repository at this point in the history

  3. More cleanup on Linux.

    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c9852a5 View commit details
    Browse the repository at this point in the history

  4. Fix rebuild.

    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5f96265 View commit details
    Browse the repository at this point in the history

  5. Fix "NODE_JS is set to empty value in D:\a\_work\1\s\src\mono\browser… 

    …\emsdk\emscripten\.emscripten"
    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0335335 View commit details
    Browse the repository at this point in the history

  6. Fix "BINARYEN_ROOT is set to empty value in \src\mono\browser\emsdk\e… 

    …mscripten\.emscripten"
    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    89148e8 View commit details
    Browse the repository at this point in the history

  7. Workaround - set EMSKD_PATH for native build separately.

    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bd9179b View commit details
    Browse the repository at this point in the history

  8. Cleanup.

    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7da3a6c View commit details
    Browse the repository at this point in the history

  9. Fix "Specified Emscripten sdk at $(EMSDK_PATH) is missing some paths:… 

    … $(EmscriptenPythonToolsPath)".
    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1a94c15 View commit details
    Browse the repository at this point in the history

  10. Fix: path to python "is not recognized as an internal or external com… 

    …mand" + ensure node path is formatted correctly.
    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d8b8a7c View commit details
    Browse the repository at this point in the history

  11. Missing change for the fix in the previous commit.

    @ilonatommy
    ilonatommy committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6246fed View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Fix wbt: add missing env vars

    @ilonatommy
    ilonatommy committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6fd5e6f View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Missing "bin" part of node path.

    @ilonatommy
    ilonatommy committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fbb71be View commit details
    Browse the repository at this point in the history

  2. Lib tests have "bin" in the end of node path but wbt do not, satisfy … 

    …both.
    @ilonatommy
    ilonatommy committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    caf5379 View commit details
    Browse the repository at this point in the history

  3. Wrong condition, c&p error.

    @ilonatommy
    ilonatommy committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2a34403 View commit details
    Browse the repository at this point in the history

  4. Fix WBT: "binaryen executable not found (%HostBinaryenDir%\bin\wasm-o… 

    …pt.exe). Please check your binaryen installation"
    @ilonatommy
    ilonatommy committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fbd9744 View commit details
    Browse the repository at this point in the history

  5. "EndsWith" did not detect the need to append "bin" correctly.

    @ilonatommy
    ilonatommy committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8ed999c View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Revert redundant changes to user-app targets.

    @ilonatommy
    ilonatommy committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    383e5cd View commit details
    Browse the repository at this point in the history

  2. Missing change revert

    @ilonatommy
    ilonatommy committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2dd0adb View commit details
    Browse the repository at this point in the history

  3. Feedback.

    @ilonatommy
    ilonatommy committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    65e574e View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'main' into fix-105439-changing-runtime-only

    @ilonatommy
    ilonatommy committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7d70eb6 View commit details
    Browse the repository at this point in the history

  2. Import after SetupPackagePaths finishes.

    @ilonatommy
    ilonatommy committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1b7befc View commit details
    Browse the repository at this point in the history

  3. Fix

    @ilonatommy
    ilonatommy committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5830355 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Remove redundant comments.

    @ilonatommy
    ilonatommy committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fb1738b View commit details
    Browse the repository at this point in the history

  2. WasmApp.InTree.props are loaded too late. Move the props back to de… 

    …faults.props.
    @ilonatommy
    ilonatommy committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5f8908b View commit details
    Browse the repository at this point in the history

  3. Fix missing slash in the end of the path.

    @ilonatommy
    ilonatommy committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8c9a3f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Remove whitespace change.

    @ilonatommy
    ilonatommy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b14d7a9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-105439-changing-runtime-only

    @ilonatommy
    ilonatommy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    755c343 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Make sure properties to build nuget paths on helix are not empty.

    @ilonatommy
    ilonatommy committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6daf79e View commit details
    Browse the repository at this point in the history

  2. Debugging commit, see where are packages.

    @ilonatommy
    ilonatommy committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    08f86f3 View commit details
    Browse the repository at this point in the history

  3. More debugging.

    @ilonatommy
    ilonatommy committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4744846 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fallback for helix.

    @ilonatommy
    ilonatommy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    574548b View commit details
    Browse the repository at this point in the history

  2. Cleanup needed when we have the fallback.

    @ilonatommy
    ilonatommy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f9acf9f View commit details
    Browse the repository at this point in the history