Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the rest of the SimdAsHWIntrinsic support #106594

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

tannergooding
Copy link
Member

This removes quite a bit of complexity and ensures that Vector<T> handling is identical to the handling for the fixed sized vector types on exposed APIs.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding
Copy link
Member Author

This one is for .NET 10 only, it does not need backport

@tannergooding tannergooding added this to the 10.0.0 milestone Aug 26, 2024
@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-x86, jitstress-isas-arm64, Fuzzlyn

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib This is ready for review.

This removes the last of the handling that was specific to System.Numerics.* namespace and fully unifies it with the handling in the System.Runtime.Intrinsics.* namespace by mapping across the APIs during import.

This results in some fairly significant size and throughput wins for both x64 and Arm64, mostly stemming from places that the System.Numerics.* handling wasn't going down the same code paths and lighting up the same scenarios: https://dev.azure.com/dnceng-public/public/_build/results?buildId=856735&view=ms.vss-build-web.run-extensions-tab

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! I've noticed some missing ternary ops (avx512) among the regressions but I guess it's not a big deal

@tannergooding
Copy link
Member Author

I've noticed some missing ternary ops (avx512) among the regressions but I guess it's not a big deal

Yeah, we've got a tracking issue for those: #107619 and #90075

We get a lot of the cases, but there's a bit of slightly more advanced folding we still want to handle

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants