Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] Fix building of method signature names for class type variables #106654

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

elinor-fung
Copy link
Member

  • Use type instantiation (instead of method) for formatting signature with class type variables
  • Handle creating instantiation for arrays to pass to signature formatting helper

Examples:

-System.Collections.Generic.Dictionary`2[[System.Int32, System.Private.CoreLib],[System.UInt64, System.Private.CoreLib]].Add(!!0, !!1)
+System.Collections.Generic.Dictionary`2[[System.Int32, System.Private.CoreLib],[System.UInt64, System.Private.CoreLib]].Add(Int32, UInt64)

-System.Object[].Set(Int32, !!0)
+System.Object[].Set(Int32, System.Object)

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 19, 2024
@elinor-fung elinor-fung added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@elinor-fung elinor-fung merged commit cc76011 into dotnet:main Aug 19, 2024
147 of 149 checks passed
@elinor-fung elinor-fung deleted the cdac-method-sig branch August 19, 2024 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants