Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error check for CipherUpdate #106657

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

vcsjones
Copy link
Member

We weren't checking the return value for CipherUpdate, so add the return value check. While we are here, make sure outl is always set when the native shim function exits.

There is currently no known way to hit this or write a test for it, as the inputs to CipherUpdate are checked up-front and handled appropriately.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@vcsjones vcsjones merged commit 886a056 into dotnet:main Aug 19, 2024
95 of 98 checks passed
@vcsjones vcsjones deleted the ossl-cipher-update branch August 19, 2024 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants