-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Fix processing of satellite assemblies from referenced assembly during publish #106696
Conversation
…ectReference) where ResolvedFrom contains {RawFileName}
…blish because they can be resource assemblies from References
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Outdated
Show resolved
Hide resolved
src/mono/wasm/testassets/WasmBasicTestApp/ResourceLibrary/ResourceAccessor.cs
Outdated
Show resolved
Hide resolved
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…oes through the same path and are not discovered by nested publish
This AOT failure didn't find app assembly AOT module. Based on output it seems it didn't run main (out it didn't provide console writes), but return of 42 from nodejs is expected https://helix.dot.net/api/2019-06-17/jobs/61a94806-100b-49f2-b546-f69dd33afd15/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.WasmTemplateTests/console |
In console app published trimmed, it copies all satellite assemblies, even for linked out libraries |
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10720328255 |
…mbly during publish (dotnet#106696)
…mbly during publish (dotnet#106696)
RelatedAsset
to satellite assemblies from<Reference />
.ResolveAssemblyReferencesFindRelatedSatellites=true
to nested publish to enable searching for satellite assemblies.<ProjectReference />
&<Reference />
.Context
ResolveAssemblyReferencesFindRelatedSatellites
is set to false by defaultFixes #105937