Correct lengths of Chinese lunisolar calendar months 8 and 9 in 2057. #107038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
@elyoh thanks a lot for helping with this issue. Could you please add a small test case validating the value we are fixing? just to ensure moving forward we'll not regress the cases we are fixing. Let me know if you need any help guiding adding such test. |
This was referenced Aug 27, 2024
|
@elyoh did you have chance to address my comment #107038 (comment)? |
tarekgh
approved these changes
Aug 29, 2024
|
I think I have added a suitable test for this. |
tarekgh
reviewed
Aug 30, 2024
...s/System.Globalization.Calendars.Tests/System/Globalization/ChineseLunisolarCalendarTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 30, 2024
Local testing undertaken.
|
Thanks @elyoh for your help with this issue! |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…dotnet#107038) * Correct lengths on lunar months 8 and 9 in 2057. Fixes dotnet#107032 * Add test. * Correct comment. * Addresses PR feedback. Local testing undertaken. --------- Co-authored-by: Tarek Mahmoud Sayed <10833894+tarekgh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107032