Let the debugger knows DATAS is on #107115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc |
This was referenced Aug 29, 2024
mangod9
reviewed
Aug 29, 2024
| @@ -113,6 +113,11 @@ inline bool IsBackgroundGCEnabled() | |||
| return (g_gcDacGlobals->minor_version_number & 2) == 0; | |||
| } | |||
|
|
|||
| inline bool IsDatasEnabled() | |||
| { | |||
| return (g_gcDacGlobals->minor_version_number & 4) == 0; | |||
There was a problem hiding this comment.
should 4 be defined as a constant somewhere? Same for other constants above actually.
There was a problem hiding this comment.
It is a questionable practice to overload version number to mean something else. Should this rather be a new variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if the debugger (e.g.
!eeheap) can tell us if DATAS is on.Right now,
IsDatasEnabledis not called by anyone, yet.