-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for VBS in CngKeyCreationOptions #107301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcsjones
added
the
documentation
Documentation bug or enhancement, does not impact product or test code
label
Sep 3, 2024
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
reviewed
Sep 3, 2024
...aries/System.Security.Cryptography/src/System/Security/Cryptography/CngKeyCreationOptions.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Sep 3, 2024
...aries/System.Security.Cryptography/src/System/Security/Cryptography/CngKeyCreationOptions.cs
Show resolved
Hide resolved
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
bartonjs
reviewed
Sep 3, 2024
...aries/System.Security.Cryptography/src/System/Security/Cryptography/CngKeyCreationOptions.cs
Outdated
Show resolved
Hide resolved
…/Cryptography/CngKeyCreationOptions.cs
bartonjs
approved these changes
Sep 3, 2024
Comment on lines
+30
to
+31
/// Instructs Virtualization-based security (VBS) to protect the client key with a per-boot key | ||
/// when combined with <see cref="RequireVbs"/> or <see cref="PreferVbs"/> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/// Instructs Virtualization-based security (VBS) to protect the client key with a per-boot key | |
/// when combined with <see cref="RequireVbs"/> or <see cref="PreferVbs"/> . | |
/// Instructs Virtualization-based security (VBS) to protect the client key with a key that can't | |
/// be reused across boot cycles when combined with <see cref="RequireVbs"/> or | |
/// <see cref="PreferVbs"/>. |
This was referenced Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Security
documentation
Documentation bug or enhancement, does not impact product or test code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less a repeat of the Win32 docs, trimmed down a bit.