[release/9.0] Fix string case-insensitive comparisons in Globalization invariant mode #107311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
artl93
added
Servicing-approved
artl93
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106828
Backport of #107268 to release/9.0
/cc @tarekgh
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
We release containers which enable Globalization invariant mode by default. When comparing string in general, the rule of
if s1 < s2 and s2 < s3, then s1 < s3should hold true either using case-sensitive or insensitive comparison. We had a bug when comparing strings as insensitive in invariant mode which can return wrong result. The attached issue gives an example of that. Customers run into this issue and causing them to work around it for their customers too. Here is example of the customer comment #106828 (comment). This issue may meet the bar of 8.0 servicing too.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Passed all regression tests in addition to adding a new test to cover the failing case.
Risk
Low, the fix is scoped to the Globalization Invariant mode and when using case insensitive comparison. We have not changed any logic more than returning the correct integer value from the comparison (positive, negative, or zero value).
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.