Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s390x] Use consistent shift instruction #107559

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

saitama951
Copy link
Contributor

@saitama951 saitama951 commented Sep 9, 2024

Fixes #107387
The slag instructions throws an undefined behavior when moving from Float to Int in OP_MOVE_I4_TO_F

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 9, 2024
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(caveat: I don't know s390x assembly - just reviewing for code structure)

@saitama951
Copy link
Contributor Author

Can we merge this?

@lambdageek lambdageek merged commit 4930e1b into dotnet:main Sep 11, 2024
78 of 81 checks passed
@saitama951
Copy link
Contributor Author

@lambdageek can we backport this to release/9.0?

@lambdageek
Copy link
Member

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10836189535

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
Fixes dotnet#107387
The slag instructions throws an undefined behavior when moving from Float to Int in OP_MOVE_I4_TO_F
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-s390x Related to s390x architecture (unsupported) area-Codegen-JIT-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[s390x] Undefined behaviour in float32
2 participants