Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DiagnosticSource] Add version event to EventSources used for out-of-proc monitoring #107576

Merged
merged 8 commits into from
Sep 12, 2024
Merged

[DiagnosticSource] Add version event to EventSources used for out-of-proc monitoring #107576

merged 8 commits into from
Sep 12, 2024

Conversation

CodeBlanch
Copy link
Contributor

A couple features were added in .NET 9:

The issue is consumers/listeners need to know if a 9+ version of DS is in play in the target process before they can use those things.

The idea here is to add a version event consumers/listeners can enable first to inspect the target version before enabling events.

/cc @noahfalk @tarekgh

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 9, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 11, 2024
Open
Open
@CodeBlanch CodeBlanch marked this pull request as ready for review September 11, 2024 22:16
@tarekgh
Copy link
Member

tarekgh commented Sep 11, 2024

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

noahfalk
noahfalk reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to hit submit earlier. These are just minor tweaks but also +1 on the request to do versions with the build rather than with reflection over attributes.

...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs Outdated Show resolved Hide resolved
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs Outdated Show resolved Hide resolved
...es/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Outdated Show resolved Hide resolved
@tarekgh
Copy link
Member

tarekgh commented Sep 11, 2024

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

tarekgh
tarekgh approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CodeBlanch for providing the change

@tarekgh tarekgh merged commit d05110c into dotnet:main Sep 12, 2024
83 of 93 checks passed
@tarekgh
Copy link
Member

tarekgh commented Sep 12, 2024

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10835863932

@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Merged
4 tasks
@CodeBlanch CodeBlanch deleted the ds-eventsource-version-event branch September 12, 2024 18:57
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
@CodeBlanch @ericstj
@tarekgh @jtschuster
[DiagnosticSource] Add version event to EventSources used for out-of-…
1d2d654 
…proc monitoring (dotnet#107576)

* Add a version event to DS event sources.

* Tweaks.

* Code review.

* Code review, bug fixes, and tests.

* Fix GenerateFileFromTemplate and make it work with incremental build

* Test fixes and code review.

* Apply suggestions from code review

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Tarek Mahmoud Sayed <10833894+tarekgh@users.noreply.github.com>
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@CodeBlanch @ericstj
@tarekgh @sirntar
[DiagnosticSource] Add version event to EventSources used for out-of-…
4348dfa 
…proc monitoring (dotnet#107576)

* Add a version event to DS event sources.

* Tweaks.

* Code review.

* Code review, bug fixes, and tests.

* Fix GenerateFileFromTemplate and make it work with incremental build

* Test fixes and code review.

* Apply suggestions from code review

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Tarek Mahmoud Sayed <10833894+tarekgh@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj left review comments

@jkotas jkotas jkotas left review comments

@noahfalk noahfalk noahfalk left review comments

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
area-System.Diagnostics.Tracing community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CodeBlanch @tarekgh @noahfalk @jkotas @ericstj