Remove BaseDomain
#107652
Merged
Remove BaseDomain
#107652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
The `BaseDomain` concept is no longer useful now that we don't have shared domains or multiple app domains. It has been gutted enough and usages moved to directly use `AppDomain` or `SystemDomain` that it can just be removed now. With this change, `AppDomain` and `SystemDomain` are separate classes with no shared base.
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
The `BaseDomain` concept is no longer useful now that we don't have shared domains or multiple app domains. It has been gutted enough and usages moved to directly use `AppDomain` or `SystemDomain` that it can just be removed now. With this change, `AppDomain` and `SystemDomain` are separate classes with no shared base.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BaseDomainconcept is no longer useful now that we don't have shared domains or multiple app domains. It has been gutted enough and usages moved to directly useAppDomainorSystemDomainthat it can just be removed now. With this change,AppDomainandSystemDomainare separate classes with no shared base.cc @jkotas @AaronRobinsonMSFT