PersistedAssemblyBuilder: fix IL reference tokens to another generated assembly members

[buyaa-n]

A generated assembly member tokens will not populated properly until its saved. Therefore we reserve Blob for such tokens and fill-in during assembly.Save() operation. As per this design current code reserves tokens in case the IL referencing TypeBuilder, FieldBuilder, MethodBuilder, ConstructorBuilder or generic type parameter references TypeBuilder. This caused a bug when members are refenced from another generated assembly, tokens are reserved as it was in the same assembly instead it should have reference tokens to that assembly

The fix basically involves checking if the referenced member is in a same module, that is pretty much adding another check && Equals(member.Module) and make the static methods instance in order to use the Equals(object) instance method of the module

Fixes #107658

[jkotas]

Thank you!

[buyaa-n]

/backport to release/9.0

[github-actions]

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10815345665

[leppie]

Thanks!

Will this be in the daily builds?

Edit: I see I have to look for the commits of the 'rolling' builds. Seems runtime is a day or 2 behind, but will look for when it comes.

[buyaa-n]

I don't see it made to daily build yet https://github.com/dotnet/sdk/blob/main/documentation/package-table.md

[leppie]

Arrived with 9.0.100-rc.2.24463.1.

Hoping there is no more issues!

Update: No other issues detected, all persisted dll's passes IL verify checks.

[leppie]

Good news! Successfully compiled all 234 libraries I have in IronScheme.

Thanks a lot for your work on this, my 5 users will be ecstatic!

Nice speed bump too compared to .NET 2 x86!

.NET 2 x86

Statistics for 'total compile time':
  Real Time:  65306ms
  CPU Time:   29219ms
  User Time:  32578ms
  GC's:       1167

.NET 9

Statistics for 'total compile time':
  Real Time:  48039ms
  CPU Time:   26656ms
  User Time:  28469ms
  GC's:       1326

[buyaa-n]

Great to hear @leppie, thank you for giving it try and reporting issues found!

[leppie]

Great to hear @leppie, thank you for giving it try and reporting issues found!

Pleasure. IronScheme tends to break things, so a pretty good coverage test.

It is a single assembly that run on any .NET 2 onwards basically (MS or Mono). There is a very small PAL that is loaded dynamically from embedded resources. If the platform can run dotnet, it can run IronScheme. I have even ran it on my TV.

Persisted compilation will just make it a lot faster for limited platforms, instead of relying on the incremental (runtime) compiler.