WebSocket Feedback Follow-up #107662
Merged
WebSocket Feedback Follow-up #107662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
CarnaViire
commented
Sep 10, 2024
CarnaViire
commented
Sep 10, 2024
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/AsyncMutex.cs
Show resolved
Hide resolved
CarnaViire
commented
Sep 10, 2024
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.cs
Outdated
Show resolved
Hide resolved
|
The only thing I didn't address was UnsafeOnCompleted because I feel like there's more things that are not quite right/expected with activities here, so quick investigation wasn't enough for me to find out what it is and whether it's just my own lack of knowledge. So I decided to address it separately. (cc @MihaZupan) |
MihaZupan
reviewed
Sep 13, 2024
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/WebSocketStateHelper.cs
Outdated
Show resolved
Hide resolved
…WebSocketStateHelper.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
stephentoub
reviewed
Sep 13, 2024
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 13, 2024
src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/WebSocketStateHelper.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Sep 13, 2024
This was referenced Sep 17, 2024
|
runtime-dev-innerloop hang is dotnet/dnceng#3879 |
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Fixes * State validation update * Roll back dispose changes, fix mutex logging * Roll back observe changes * Add internal flags enum for states * Update src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/WebSocketStateHelper.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> * Feedback --------- Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing remaining PR feedback from #105841
cc @MihaZupan @stephentoub