Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NRBF] Comments and bug fixes from security review #107735

Merged
merged 9 commits into from
Sep 16, 2024
Merged

[NRBF] Comments and bug fixes from security review #107735

merged 9 commits into from
Sep 16, 2024

Commits on Sep 12, 2024

  1. copy comments and asserts from Levis internal code review

    @adamsitnik
    adamsitnik committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f3f87a3 View commit details
    Browse the repository at this point in the history

  2. apply Levis suggestion: don't store Array.MaxLength as a const, as it… 

    … may change in the future
    @adamsitnik
    adamsitnik committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8a42d8b View commit details
    Browse the repository at this point in the history

  3. add missing and fix some of the existing comments

    @adamsitnik
    adamsitnik committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    88b9dba View commit details
    Browse the repository at this point in the history

  4. first bug fix: SerializationRecord.TypeNameMatches should throw Argum… 

    …entNullException for null Type argument
    @adamsitnik
    adamsitnik committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    969a2ef View commit details
    Browse the repository at this point in the history

  5. second bug fix: SerializationRecord.TypeNameMatches should know the d… 

    …ifference between SZArray and single-dimension, non-zero offset arrays (example: int[] and int[*])
    @adamsitnik
    adamsitnik committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    61a9b14 View commit details
    Browse the repository at this point in the history

  6. third bug fix: don't cast bytes to booleans

    @adamsitnik
    adamsitnik committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fcb3c8a View commit details
    Browse the repository at this point in the history

  7. fourth bug fix: don't cast bytes to DateTimes

    @adamsitnik
    adamsitnik committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    88504ef View commit details
    Browse the repository at this point in the history

  8. add one test case that I've forgot in previous PR

    @adamsitnik
    adamsitnik committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    581c1fc View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. address code review feedback

    @adamsitnik
    adamsitnik committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d68a423 View commit details
    Browse the repository at this point in the history