Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Remove redundant !fgIsCommaThrow(morphedTree) assert #107760

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 12, 2024

Backport of #107624 to release/9.0

/cc @EgorBo

Customer Impact

  • Customer reported
  • Found internally

The fairly rare SIMD pattern may cause Debug/Checked only asserts in JIT. Just to keep release/9.0 branch cleaner for outerloop testing

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Test is added

Risk

Zero

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 12, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review. we can merge when ready

@jeffschwMSFT
Copy link
Member

@EgorBo @JulieLeeMSFT today is the snap, please take a look at the PR failures

@EgorBo
Copy link
Member

EgorBo commented Sep 16, 2024

@EgorBo @JulieLeeMSFT today is the snap, please take a look at the PR failures

Seems like an unrelated timeout, I've restarted the job

@jeffschwMSFT jeffschwMSFT merged commit 6d5182a into release/9.0 Sep 16, 2024
10 checks passed
@jkotas jkotas deleted the backport/pr-107624-to-release/9.0 branch September 18, 2024 21:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants